Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues caused by the new 'masked' appearance #6088

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Fixed issues caused by the new 'masked' appearance #6088

merged 3 commits into from
Apr 26, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Apr 12, 2024 •
edited
Loading

Closes #6072
Closes #6073
Closes #6075
Closes #6080

Why is this the best possible solution? Were any other approaches considered?

#6073 has been fixed in 24d2b99 - as we have discussed it doesn't make sense to mix thousands-sep with masked (masked should win).
#6072 and #6075 have been fixed in 6628186 by fixing setting inputtypes.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This should fix the issues we had with text and number questions with the new masked appearance. Please test the form attached below but also the All question types one to make sure text and number questions without the masked appearance work well.

Do we need any specific form for testing your changes? If so, please attach one.

The form attached to #6008

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 12, 2024 13:51
@grzesiek2010 grzesiek2010 requested a review from seadowg April 12, 2024 13:51
@grzesiek2010 grzesiek2010 changed the title Do not allow to mix 'thousands-sep' with 'masked' Fixed issue caused by the new 'masked' appearance Apr 12, 2024
@grzesiek2010 grzesiek2010 marked this pull request as draft April 12, 2024 13:53
@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 12, 2024 14:00
@grzesiek2010 grzesiek2010 changed the title Fixed issue caused by the new 'masked' appearance Fixed issues caused by the new 'masked' appearance Apr 15, 2024
seadowg
seadowg requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request addresses three issues but only #6072 is worth explaining. To me, it seems like an Android bug since only number questions were affected. It looks like moving the cursor needs to be delayed a little bit so I used the post method like in a few other places of the app.

These no post in the changes. Is there a commit missing perhaps? Or I guess this comment might be out of date.

@grzesiek2010
Copy link
Member Author

These no post in the changes. Is there a commit missing perhaps? Or I guess this comment might be out of date.

Yeah, it was the old version I forgot to update the description.

@grzesiek2010 grzesiek2010 requested a review from seadowg April 15, 2024 13:06
seadowg
seadowg requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add tests for the changes to WidgetAnswerText here.

@grzesiek2010 grzesiek2010 force-pushed the COLLECT-6073 branch 3 times, most recently from 74c8e40 to 87544ac Compare April 18, 2024 10:52
@grzesiek2010 grzesiek2010 force-pushed the COLLECT-6073 branch 2 times, most recently from e043354 to 5dd63fb Compare April 18, 2024 11:38
@grzesiek2010 grzesiek2010 requested a review from seadowg April 18, 2024 21:47
@grzesiek2010
Copy link
Member Author

I think we should add tests for the changes to WidgetAnswerText here.

Done.

@seadowg seadowg merged commit bf66ba3 into getodk:master Apr 26, 2024
6 checks passed
@grzesiek2010 grzesiek2010 mentioned this pull request Apr 30, 2024
Closed
@WKobus
Copy link

WKobus commented May 9, 2024

Tested with Success!

Verified on devices with Android 11

Verified cases:

@dbemke
Copy link

dbemke commented May 9, 2024

Tested with Success!

Verified on devices with Android 10, 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seadowg seadowg seadowg approved these changes

Assignees
No one assigned
Labels
behavior verified
Projects
None yet
Milestone
No milestone
4 participants
@grzesiek2010 @WKobus @dbemke @seadowg